From fe41f57df59c7f2a11d80eaaebf08d3a3a51a6d5 Mon Sep 17 00:00:00 2001
From: h5p9sl <21267024+h5p9sl@users.noreply.github.com>
Date: Thu, 13 May 2021 22:07:11 -0600
Subject: Add error handling

---
 create_thread.php | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

(limited to 'create_thread.php')

diff --git a/create_thread.php b/create_thread.php
index 6fb7df9..a203b39 100644
--- a/create_thread.php
+++ b/create_thread.php
@@ -10,6 +10,7 @@
 <h2>Create a new thread</h2>
 <?php
 include_once 'includes/Session.php';
+include_once 'includes/error.php';
 if (!Session::get()->is_signed_in()) {
 	trigger_error('You must be <a href="signin.php">signed in</a> to create a thread.');
 	exit();
@@ -44,6 +45,7 @@ if (!Session::get()->is_signed_in()) {
 <?php
 include_once 'includes/functions_post.php';
 include_once 'includes/functions_thread.php';
+include_once 'includes/error.php';
 
 if ($_SERVER['REQUEST_METHOD'] == 'POST') {
 	$post_content = filter_input(INPUT_POST, 'post_content', FILTER_SANITIZE_STRING);
@@ -51,7 +53,7 @@ if ($_SERVER['REQUEST_METHOD'] == 'POST') {
 	$thread_cat = filter_input(INPUT_POST, 'thread_cat', FILTER_SANITIZE_NUMBER_INT);
 
 	if (empty($thread_subject) or !$thread_subject) {
-		echo 'Thread subject cannot be empty';
+		trigger_error('Thread subject cannot be empty');
 	} else {
 		$thread_id = create_thread($thread_subject, $thread_cat);
 		create_post($post_content, $thread_id, $thread_cat);
-- 
cgit v1.2.3


From 2b03ca63d06ec5da45c887ef7cb3daa35a8642f7 Mon Sep 17 00:00:00 2001
From: h5p9sl <21267024+h5p9sl@users.noreply.github.com>
Date: Thu, 13 May 2021 22:27:06 -0600
Subject: Disallow empty post content when creating threads

---
 create_thread.php | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

(limited to 'create_thread.php')

diff --git a/create_thread.php b/create_thread.php
index a203b39..976bd9f 100644
--- a/create_thread.php
+++ b/create_thread.php
@@ -27,7 +27,7 @@ if (!Session::get()->is_signed_in()) {
 	$categories = get_all_categories();
 
 	if (count($categories) == 0) {
-		echo 'There are no categories to post to!';
+		trigger_error('There are no categories to post to!');
 	} else {
 		echo '<select name="thread_cat">';
 
@@ -52,8 +52,21 @@ if ($_SERVER['REQUEST_METHOD'] == 'POST') {
 	$thread_subject = filter_input(INPUT_POST, 'thread_subject', FILTER_SANITIZE_STRING);
 	$thread_cat = filter_input(INPUT_POST, 'thread_cat', FILTER_SANITIZE_NUMBER_INT);
 
+	$errors = array();
 	if (empty($thread_subject) or !$thread_subject) {
-		trigger_error('Thread subject cannot be empty');
+		$errors[] = 'Thread subject cannot be empty';
+	}
+	if (empty($post_content) or !$post_content) {
+		$errors[] = 'Thread body cannot be empty';
+	}
+
+	if (!empty($errors)) {
+		$errstr = 'Please check the following problems: <ul>';
+		foreach ($errors as $err) {
+			$errstr .= '<li>' . $err . '</li>';
+		}
+		$errstr .= '</ul>';
+		trigger_error($errstr);
 	} else {
 		$thread_id = create_thread($thread_subject, $thread_cat);
 		create_post($post_content, $thread_id, $thread_cat);
-- 
cgit v1.2.3